[Offloading] [Bugfix] Fix disk offloading of models with explicit tensor dtypes#46849
Merged
Merged
Conversation
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
This was referenced Jun 23, 2026
kylesayrs
changed the title
Contributor
|
CI Dashboard: View test results in Grafana |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
tid2eidwith the incorrect precision, leading to incorrect hash gate valuestid2eidto round to out-of-bounds values, not to mention that the values were incorrectChanges
model.dtypeto determine the load dtype for disk-offloaded weights, instead use the dtype of the associated meta tensor in the meta model. The meta tensor dtype is already the correct dtype, influenced by thelocal_torch_dtypeload contextdtypefield is read byOffloadedWeightsLoaderhereTesting
test_disk_onload_dtypeSuggested Reviewers
@SunMarc @zucchini-nlp